search

pmelchior / spender

Spectrum encoder and decoder
MIT License
35 stars 11 forks source link

Update setup.py #49

Closed EiffL closed 9 months ago

EiffL commented 9 months ago

Add missing dependency and automated install of interp1d

pmelchior commented 9 months ago

Thanks for your PR. We used to have torchinterp1d listed with its git repo location, and this caused some trouble. I vaguely remember pypi was acting up with this config. The only difference I see is that you provide the egg in the URL. Is that the magic trick to make it work?

EiffL commented 9 months ago

Ah, good point, I haven't tested what happens on pypi with this.... let me try to push my fork to test pypi and see what happens there

EiffL commented 9 months ago

annnnd... yeah, you are right :-( 

INFO     Response from https://test.pypi.org/legacy/:                                                  
         400 Invalid value for requires_dist. Error: Can't have direct dependency: 'torchinterp1d@     
         git+https://github.com/aliutkus/torchinterp1d.git#egg=torchinterp1d'

And ChatGPT does not believe there is a way to solve this that does not involve pushing torchinterp1d to pypi.

So.... maybe I'll just edit my PR to only add nflows and leave the rest as it is...

pmelchior commented 9 months ago

It's not that I haven't tried the pypi route with the maintainer: https://github.com/aliutkus/torchinterp1d/issues/18 Maybe you can raise it there again.