search

pmelsted / bifrost

Bifrost: Highly parallel construction and indexing of colored and compacted de Bruijn graphs
BSD 2-Clause "Simplified" License
201 stars 25 forks source link

Make install error: Missing File #59

Closed FKCodebase closed 2 years ago

FKCodebase commented 2 years ago

Hi, we were trying to update Bifrost and installed "from source" as shown in the readme.

However, the "make install" call crashed because the xxhash.c file is missing.
We worked aroud this by using an older version of the file (BFG_VERSION 1.0.5). Is this workaround save?

Kind regards Fabian Kolesch

GuillaumeHolley commented 2 years ago

Hi Fabian,

Thank you for reporting this issue, this is caused by Cmake requiring XXHash files which I have removed as a dependency in Bifrost 1.0.6+ versions. For some reasons, I must have put those back in Bifrost 1.0.6.3.

Anyway, I have fixed the Cmake files and you can use them right now. I do not think that using the Cmake files from v1.0.5 with the code from 1.0.6.3 is safe (you should have the same issue). Better be safe than sorry and use the updated ones :)

Let me know if you still have an issue with the install of the new version.

Guillaume