search

pmem / libpmemobj-cpp

C++ bindings & containers for libpmemobj
https://pmem.io
Other
107 stars 76 forks source link

CI: add step to configure msbuild on Windows #1246

Closed lukaszstolarczuk closed 2 years ago

lukaszstolarczuk commented 2 years ago

This change is Reviewable

lukaszstolarczuk commented 2 years ago

:lgtm: if the build passes ;d

Reviewed 1 of 1 files at r1. Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lukaszstolarczuk)

spoilers - it will should: https://github.com/lukaszstolarczuk/libpmemobj-cpp/actions/runs/1824878444 😉

codecov[bot] commented 2 years ago

Codecov Report

Merging #1246 (e608f12) into stable-1.9 (825ab57) will increase coverage by 2.40%. The diff coverage is n/a.

@@              Coverage Diff               @@
##           stable-1.9    #1246      +/-   ##
==============================================
+ Coverage       87.60%   90.01%   +2.40%     
==============================================
  Files              40       40              
  Lines            3847     3824      -23     
==============================================
+ Hits             3370     3442      +72     
+ Misses            477      382      -95
Flag Coverage Δ
tests_clang_debug_cpp17 47.89% <ø> (+16.87%) :arrow_up:
tests_gcc_debug 93.69% <ø> (+0.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/libpmemobj++/condition_variable.hpp 67.39% <0.00%> (-12.10%) :arrow_down:
include/libpmemobj++/detail/pair.hpp 88.88% <0.00%> (-11.12%) :arrow_down:
include/libpmemobj++/timed_mutex.hpp 54.83% <0.00%> (-3.79%) :arrow_down:
include/libpmemobj++/pexceptions.hpp 33.33% <0.00%> (ø)
include/libpmemobj++/detail/pool_data.hpp 100.00% <0.00%> (ø)
include/libpmemobj++/persistent_ptr_base.hpp 100.00% <0.00%> (ø)
...ude/libpmemobj++/container/concurrent_hash_map.hpp 86.41% <0.00%> (+0.02%) :arrow_up:
include/libpmemobj++/container/array.hpp 100.00% <0.00%> (+0.54%) :arrow_up:
include/libpmemobj++/pool.hpp 94.59% <0.00%> (+1.44%) :arrow_up:
include/libpmemobj++/container/basic_string.hpp 96.79% <0.00%> (+1.68%) :arrow_up:
... and 14 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more