search

pmem / ndctl

A "device memory" enabling project encompassing tools and libraries for CXL, NVDIMMs, DAX, memory tiering and other platform memory device topics.
Other
270 stars 139 forks source link

libtracefs header location not checked #234

Closed hramrach closed 1 year ago

hramrach commented 1 year ago

Needed

find . -name *.c -o -name *.h | xargs sed -i -e "s,#include <tracefs/tracefs.h>,#include <libtracefs/tracefs.h>,"

Looks like the include should be , and the -I from pkgconfig should be used:

pkgconf --cflags libtracefs -I/usr/include/libtracefs -I/usr/include/traceevent

stellarhopper commented 1 year ago

@hramrach hm looks like this might need another distro-specific include searching dance like we had for iniparser. Fedora has it in /usr/include/tracefs/tracefs.h, and there's not a /usr/include/libtracefs/ at all.

stellarhopper commented 1 year ago

Oh, agreed with include since there is a pkgconf. I'll make that change.

stellarhopper commented 1 year ago

Fixes sent: https://lore.kernel.org/linux-cxl/20230223-meson-build-fixes-v1-0-5fae3b606395@intel.com I'll do a 76.1 with these once reviewed

stellarhopper commented 1 year ago

76.1 is now out with these fixes. Thanks for the reports @hramrach