ldorau commented 7 years ago

Ref: #273

This change is

krzycz commented 7 years ago

Reviewed 11 of 11 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #307 into master will decrease coverage by 0.38%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   79.32%   78.93%   -0.39%     
==========================================
  Files          81       88       +7     
  Lines       12058    13355    +1297     
  Branches     1628     1919     +291     
==========================================
+ Hits         9565    10542     +977     
- Misses       1886     2120     +234     
- Partials      607      693      +86

Impacted Files	Coverage Δ
src/libpmemfile/syscall_early_filter.c	`60% <0%> (-20%)`	:arrow_down:
src/libpmemfile-posix/file.c	`66.2% <0%> (ø)`	:arrow_up:
src/tools/antool/syscalltable.py	`73.46% <0%> (ø)`
src/tools/antool/utils.py	`64.7% <0%> (ø)`
src/tools/antool/exceptions.py	`75% <0%> (ø)`
src/tools/antool/listsyscalls.py	`76.38% <0%> (ø)`
src/tools/antool/syscall.py	`74.76% <0%> (ø)`
src/tools/antool/antool.py	`70.18% <0%> (ø)`
src/tools/antool/syscallinfo.py	`100% <0%> (ø)`
src/libpmemfile-posix/read.c	`93.96% <0%> (+0.05%)`	:arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6f297d...5f2aacc. Read the comment docs.

pmem / pmemfile

antool: add code coverage to CodeCov.io reports #307

Codecov Report