Closed ldorau closed 7 years ago
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #310 into master will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
- Coverage 79.32% 79.29% -0.03%
==========================================
Files 81 81
Lines 12058 12060 +2
Branches 1628 1628
==========================================
- Hits 9565 9563 -2
Misses 1886 1886
- Partials 607 611 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile/syscall_early_filter.c | 60% <0%> (-20%) |
:arrow_down: |
src/libpmemfile-posix/read.c | 92.17% <0%> (-1.74%) |
:arrow_down: |
src/libpmemfile-posix/data.c | 91.86% <0%> (-0.39%) |
:arrow_down: |
src/libpmemfile-posix/rename.c | 91.09% <0%> (-0.38%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 65.93% <0%> (-0.28%) |
:arrow_down: |
src/libpmemfile-posix/dir.c | 81.81% <0%> (-0.25%) |
:arrow_down: |
src/libpmemfile/preload.c | 44.57% <0%> (+0.06%) |
:arrow_up: |
tests/posix/mt/mt.cpp | 86.45% <0%> (+1.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c6f297d...ce8d1d4. Read the comment docs.
Ref: #290
This change is