Closed ldorau closed 7 years ago
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
I tested it and it really fixes #290.
Merging #311 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 79.32% 79.33% +0.01%
==========================================
Files 81 81
Lines 12058 12061 +3
Branches 1628 1627 -1
==========================================
+ Hits 9565 9569 +4
Misses 1886 1886
+ Partials 607 606 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/read.c | 92.24% <0%> (-1.68%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 65.93% <0%> (-0.28%) |
:arrow_down: |
src/libpmemfile/preload.c | 44.57% <0%> (+0.06%) |
:arrow_up: |
src/libpmemfile-posix/rename.c | 91.93% <0%> (+0.47%) |
:arrow_up: |
tests/posix/mt/mt.cpp | 86.38% <0%> (+1.49%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c6f297d...49cecea. Read the comment docs.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
The essence of the fix is adding the condition:
if [ ! "$VLTRACE_SKIP" ]; then
to the test scripts, so that the binary log is not copied now, because it is unnecessary and wrong when the log is not regenerated. Copying the log when running parallel tests causes test failures.
Ref: #290
This change is