pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: fix moving vltrace binary log for regeneration #311

Closed ldorau closed 7 years ago

ldorau commented 7 years ago

The essence of the fix is adding the condition:

if [ ! "$VLTRACE_SKIP" ]; then

to the test scripts, so that the binary log is not copied now, because it is unnecessary and wrong when the log is not regenerated. Copying the log when running parallel tests causes test failures.

Ref: #290


This change is Reviewable

krzycz commented 7 years ago
:lgtm:

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

marcinslusarz commented 7 years ago

I tested it and it really fixes #290.

codecov-io commented 7 years ago

Codecov Report

Merging #311 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   79.32%   79.33%   +0.01%     
==========================================
  Files          81       81              
  Lines       12058    12061       +3     
  Branches     1628     1627       -1     
==========================================
+ Hits         9565     9569       +4     
  Misses       1886     1886              
+ Partials      607      606       -1
Impacted Files Coverage Δ
src/libpmemfile-posix/read.c 92.24% <0%> (-1.68%) :arrow_down:
src/libpmemfile-posix/file.c 65.93% <0%> (-0.28%) :arrow_down:
src/libpmemfile/preload.c 44.57% <0%> (+0.06%) :arrow_up:
src/libpmemfile-posix/rename.c 91.93% <0%> (+0.47%) :arrow_up:
tests/posix/mt/mt.cpp 86.38% <0%> (+1.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6f297d...49cecea. Read the comment docs.

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable