pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

Use SQLite tests to improve code coverage. #318

Closed marcinslusarz closed 7 years ago

marcinslusarz commented 7 years ago

This change is Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #318 into master will increase coverage by 0.68%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage    77.5%   78.18%   +0.68%     
==========================================
  Files          90       90              
  Lines       13811    13819       +8     
  Branches     1994     1994              
==========================================
+ Hits        10704    10805     +101     
+ Misses       2383     2293      -90     
+ Partials      724      721       -3
Impacted Files Coverage Δ
src/libpmemfile-posix/data.c 91.92% <0%> (-0.36%) :arrow_down:
src/libpmemfile-posix/rename.c 90.4% <0%> (-0.33%) :arrow_down:
src/libpmemfile-posix/file.c 67.03% <0%> (+0.27%) :arrow_up:
src/libpmemfile-posix/utils.c 73.43% <0%> (+0.42%) :arrow_up:
src/libpmemfile-posix/write.c 87.01% <0%> (+1.29%) :arrow_up:
src/libpmemfile-posix/dir.c 83.29% <0%> (+1.47%) :arrow_up:
src/libpmemfile/path_resolve.c 87.65% <0%> (+2.02%) :arrow_up:
src/libpmemfile-posix/read.c 93.19% <0%> (+2.85%) :arrow_up:
src/libpmemfile/preload.c 48.69% <0%> (+4.76%) :arrow_up:
src/libpmemfile/libpmemfile-posix-wrappers.h 54.28% <0%> (+6.85%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f1d2c4...d352783. Read the comment docs.

marcinslusarz commented 7 years ago

0.68% is not much, but it's something :).

krzycz commented 7 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable