Closed marcinslusarz closed 7 years ago
Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #320 into master will decrease coverage by
<.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #320 +/- ##
=========================================
- Coverage 77.5% 77.5% -0.01%
=========================================
Files 90 90
Lines 13811 13815 +4
Branches 1994 1994
=========================================
+ Hits 10704 10707 +3
Misses 2383 2383
- Partials 724 725 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/file.c | 65.93% <0%> (-0.83%) |
:arrow_down: |
src/libpmemfile-posix/inode.c | 77.35% <0%> (-0.35%) |
:arrow_down: |
src/libpmemfile-posix/dir.c | 81.57% <0%> (-0.25%) |
:arrow_down: |
src/libpmemfile/path_resolve.c | 85.62% <0%> (ø) |
:arrow_up: |
src/libpmemfile-posix/utils.c | 73.43% <0%> (+0.42%) |
:arrow_up: |
src/libpmemfile-posix/rename.c | 91.16% <0%> (+0.43%) |
:arrow_up: |
src/libpmemfile-posix/read.c | 91.83% <0%> (+1.49%) |
:arrow_up: |
src/libpmemfile/syscall_early_filter.c | 80% <0%> (+20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f1d2c4...3d083b4. Read the comment docs.
Reviewed 4 of 4 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Now ctest -V will print stdout and stderr of all tests.
This change is