pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

WIP: antool: add more tests and some fixes #327

Closed ldorau closed 7 years ago

ldorau commented 7 years ago

It will increase antool's code coverage more than 18% (from about 75.03% to about 93%).


This change is Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #327 into master will increase coverage by 1.61%. The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   77.11%   78.72%   +1.61%     
==========================================
  Files          92       92              
  Lines       14106    14033      -73     
  Branches     2021     1997      -24     
==========================================
+ Hits        10878    11048     +170     
+ Misses       2457     2266     -191     
+ Partials      771      719      -52
Impacted Files Coverage Δ
src/tools/antool/utils.py 100% <ø> (+35.29%) :arrow_up:
src/tools/antool/syscalltable.py 100% <ø> (+26.53%) :arrow_up:
src/tools/antool/exceptions.py 100% <ø> (+25%) :arrow_up:
src/tools/antool/antool.py 98.03% <100%> (+27.84%) :arrow_up:
src/tools/antool/syscall.py 88.05% <100%> (+13.28%) :arrow_up:
src/tools/antool/listsyscalls.py 92.42% <93.75%> (+16.14%) :arrow_up:
src/libpmemfile-posix/utils.c 71.87% <0%> (-1.57%) :arrow_down:
src/libpmemfile-posix/read.c 92.51% <0%> (-0.69%) :arrow_down:
src/libpmemfile-posix/rename.c 90.4% <0%> (-0.4%) :arrow_down:
src/libpmemfile-posix/file.c 69.5% <0%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8208e66...2600351. Read the comment docs.

marcinslusarz commented 7 years ago

Reviewed 4 of 5 files at r1, 2 of 43 files at r4. Review status: 6 of 47 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

ldorau commented 7 years ago

The code will be moved to another PR.

ldorau commented 7 years ago

https://github.com/pmem/pmemfile/pull/340

ldorau commented 7 years ago

https://github.com/pmem/pmemfile/pull/341