Codecov Report

Merging #328 into master will increase coverage by 0.03%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   77.11%   77.15%   +0.03%     
==========================================
  Files          92       92              
  Lines       14106    14106              
  Branches     2021     2021              
==========================================
+ Hits        10878    10883       +5     
+ Misses       2457     2453       -4     
+ Partials      771      770       -1

Impacted Files	Coverage Δ
src/tools/antool/syscall.py	`74.76% <100%> (ø)`	:arrow_up:
src/tools/antool/antool.py	`70.18% <100%> (ø)`	:arrow_up:
src/tools/antool/listsyscalls.py	`76.28% <80%> (ø)`	:arrow_up:
src/libpmemfile-posix/dir.c	`84.76% <0%> (-0.25%)`	:arrow_down:
src/libpmemfile-posix/file.c	`69.5% <0%> (ø)`	:arrow_up:
src/libpmemfile-posix/inode.c	`77.7% <0%> (+0.34%)`	:arrow_up:
src/libpmemfile-posix/data.c	`89.61% <0%> (+0.38%)`	:arrow_up:
src/libpmemfile-posix/rename.c	`91.6% <0%> (+0.79%)`	:arrow_up:
src/libpmemfile-posix/unlink.c	`94.93% <0%> (+2.53%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8208e66...80d938b. Read the comment docs.

GBuella commented 7 years ago

I might be too dumb for this, but it doesn't make it more clear to me. What is this variable supposed to mean? And why is a boolean assigned to it?

UNSUPPORTED_RELATIVE, UNSUPPORTED_FLAG, it looks like an error code, where zero would mean no error. Like syscall_parse_result or something.

krzycz commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

ldorau commented 7 years ago

This variable can take following values:

- RESULT_SUPPORTED = 0
- RESULT_UNSUPPORTED_YET = 1
- RESULT_UNSUPPORTED_RELATIVE = 2
- RESULT_UNSUPPORTED_FLAG = 3
- RESULT_UNSUPPORTED = 4

(the last one might be named RESULT_UNSUPPORTED_AT_ALL)

What do you think - what could be the best name for it? Marcin and I think that "unsupported_type" is better than the current one.

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

ldorau commented 7 years ago

Description changed to:

Replace:

syscall.unsupported with syscall.unsupported_type and:
RESULT_UNSUPPORTED with RESULT_UNSUPPORTED_AT_ALL

krzycz commented 7 years ago

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

pmem / pmemfile

antool: change name of a variable #328

Codecov Report