pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

Codecov.io integration improvements. #331

Closed marcinslusarz closed 7 years ago

marcinslusarz commented 7 years ago

This change is Reviewable

GBuella commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


codecov.yml, line 18 at r1 (raw file):

          - src/tools/pmemfile-cat.c
          - src/tools/pmemfile-mount.c
  ignore:

Could we also ignore src/libpmemfile/sysutil.h? It seems counterproductive to worry about the coverage of these pthread* failures: https://github.com/pmem/pmemfile/blob/master/src/libpmemfile/sys_util.h


Comments from Reviewable

sarahjelinek commented 7 years ago

What's WIP about this PR? Looks ok to me.


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

ldorau commented 7 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.


utils/docker/run-coverage.sh, line 57 at r1 (raw file):


COVERAGE=1 PYTHON_SOURCE=$WORKDIR/src/tools/antool ctest -R antool --output-on-failure
REPORT=$(find . -name ".coverage") && [ $REPORT ] && cp -f -v $REPORT . && $(which python3) $(which coverage) xml

I suggest the following changes here: https://github.com/marcinslusarz/pmemfile/pull/1/commits/1a59c568b7182f21856346e3a30076e20fdaae9b


Comments from Reviewable

ldorau commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

krzycz commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

marcinslusarz commented 7 years ago

It looks good, but doesn't work yet as expected. I'll explain it once I'll fix the issue(s).


Review status: all files reviewed at latest revision, 2 unresolved discussions.


codecov.yml, line 18 at r1 (raw file):

Previously, GBuella (Gabor Buella) wrote…
Could we also ignore src/libpmemfile/sys_util.h? It seems counterproductive to worry about the coverage of these pthread_* failures: https://github.com/pmem/pmemfile/blob/master/src/libpmemfile/sys_util.h

Sure.


Comments from Reviewable

GBuella commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

marcinslusarz commented 7 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.


utils/docker/run-coverage.sh, line 57 at r1 (raw file):

Previously, ldorau (Lukasz Dorau) wrote…
I suggest the following changes here: https://github.com/marcinslusarz/pmemfile/pull/1/commits/1a59c568b7182f21856346e3a30076e20fdaae9b

I did something similar.


Comments from Reviewable

marcinslusarz commented 7 years ago

OK, previously the 1st point in PR description wasn't working correctly.


Comments from Reviewable

marcinslusarz commented 7 years ago

Full report: https://codecov.io/gh/pmem/pmemfile/pull/331

codecov[bot] commented 7 years ago

Codecov Report

Merging #331 into master will decrease coverage by 4.48%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   77.11%   72.63%   -4.49%     
==========================================
  Files          92       64      -28     
  Lines       14106     7988    -6118     
  Branches     2021     1613     -408     
==========================================
- Hits        10878     5802    -5076     
+ Misses       2457     1670     -787     
+ Partials      771      516     -255
Flag Coverage Δ
#sqlite_tests 45.6% <ø> (?)
#tests_antool 12.21% <ø> (?)
#tests_posix_multi_threaded 26.04% <ø> (?)
#tests_posix_single_threaded 56.06% <ø> (?)
#tests_preload 44.03% <ø> (?)
Impacted Files Coverage Δ
src/libpmemfile-posix/fcntl.c 40% <0%> (-4.45%) :arrow_down:
src/libpmemfile-posix/out.c 41.77% <0%> (-1.27%) :arrow_down:
src/libpmemfile/path_resolve.c 87.57% <0%> (-1.11%) :arrow_down:
tests/posix/dirs/dirs.cpp
tests/test_backtrace.c
utils/transform/transform_pmemfile_posix.c
tests/posix/pmemfile_test.hpp
tests/preload/config/config.c
src/valgrind/valgrind.h
tests/posix/basic/basic.cpp
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8208e66...832a016. Read the comment docs.

ldorau commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

krzycz commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable