pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

preload: fix truncate for paths outside of pmemfile pool #337

Closed marcinslusarz closed 7 years ago

marcinslusarz commented 7 years ago

... when path crosses pmemfile mount point

Ref: #306


This change is Reviewable

krzycz commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

GBuella commented 7 years ago

Could you add a test which truncates a file outside a pool? I'm curious about what codecov will say. Right now, it reports 50% of the diff is covered.

sarahjelinek commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

GBuella commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r2, 2 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #337 into master will increase coverage by 0.34%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   73.66%   74.01%   +0.34%     
==========================================
  Files          64       64              
  Lines        7990     7988       -2     
  Branches     1613     1612       -1     
==========================================
+ Hits         5886     5912      +26     
+ Misses       1588     1567      -21     
+ Partials      516      509       -7
Flag Coverage Δ
#sqlite_tests 45.55% <0%> (-0.07%) :arrow_down:
#tests_antool 12.21% <0%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.99% <0%> (+0.06%) :arrow_up:
#tests_posix_single_threaded 56.09% <0%> (+0.04%) :arrow_up:
#tests_preload 46.02% <100%> (+0.58%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile/preload.c 49.25% <100%> (+2.13%) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.4%) :arrow_up:
src/libpmemfile-posix/dir.c 85.5% <0%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3f66ea...4fa45ef. Read the comment docs.

sarahjelinek commented 7 years ago

Reviewed 1 of 1 files at r2, 2 of 2 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable