pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

cmake: Make building of tests optional #339

Closed GBuella closed 7 years ago

GBuella commented 7 years ago

Introduce the BUILD_LIBPMEMFILE_POSIX_TESTS and BUILD_LIBPMEMFILE_TESTS options.


This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #339 into master will increase coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   73.66%   73.71%   +0.05%     
==========================================
  Files          64       64              
  Lines        7990     7990              
  Branches     1613     1613              
==========================================
+ Hits         5886     5890       +4     
+ Misses       1588     1586       -2     
+ Partials      516      514       -2
Flag Coverage Δ
#sqlite_tests 45.55% <ø> (+0.01%) :arrow_up:
#tests_antool 12.21% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 26.04% <ø> (+0.15%) :arrow_up:
#tests_posix_single_threaded 56.04% <ø> (-0.03%) :arrow_down:
#tests_preload 45.43% <ø> (-0.01%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/dir.c 85.5% <0%> (+0.49%) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2027609...3e47054. Read the comment docs.

krzycz commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

krzycz commented 7 years ago

Reviewed 1 of 2 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable