pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: remove pmemfile_dup* #342

Closed mslusarz closed 7 years ago

mslusarz commented 7 years ago

dup/dup2 is implemented on libpmemfile.so side without any help from libpmemfile-posix.so.


This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #342 into master will increase coverage by 0.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   73.66%   73.74%   +0.08%     
==========================================
  Files          64       64              
  Lines        7990     7984       -6     
  Branches     1613     1613              
==========================================
+ Hits         5886     5888       +2     
+ Misses       1588     1581       -7     
+ Partials      516      515       -1
Flag Coverage Δ
#sqlite_tests 45.65% <ø> (+0.04%) :arrow_up:
#tests_antool 12.22% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 26.01% <ø> (+0.09%) :arrow_up:
#tests_posix_single_threaded 56.09% <ø> (+0.05%) :arrow_up:
#tests_preload 45.52% <ø> (+0.08%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile/libpmemfile-posix-wrappers.h 53.48% <ø> (ø) :arrow_up:
src/libpmemfile-posix/file.c 70.94% <ø> (+1.16%) :arrow_up:
src/libpmemfile-posix/dir.c 85.01% <0%> (+0.24%) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3f66ea...5a895db. Read the comment docs.

krzycz commented 7 years ago
:lgtm:

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable