pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

dup3 #344

Closed GBuella closed 7 years ago

GBuella commented 7 years ago

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #344 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #344      +/-   ##
=========================================
+ Coverage   73.66%   73.7%   +0.03%     
=========================================
  Files          64      64              
  Lines        7990    7997       +7     
  Branches     1613    1615       +2     
=========================================
+ Hits         5886    5894       +8     
  Misses       1588    1588              
+ Partials      516     515       -1
Flag Coverage Δ
#sqlite_tests 45.56% <0%> (-0.05%) :arrow_down:
#tests_antool 12.2% <0%> (-0.02%) :arrow_down:
#tests_posix_multi_threaded 25.85% <0%> (-0.07%) :arrow_down:
#tests_posix_single_threaded 56.01% <0%> (-0.03%) :arrow_down:
#tests_preload 45.42% <100%> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile/syscall_early_filter.c 80% <ø> (ø) :arrow_up:
src/libpmemfile/preload.c 47.16% <100%> (+0.04%) :arrow_up:
src/libpmemfile/vfd_table.c 80.26% <100%> (+0.54%) :arrow_up:
src/libpmemfile-posix/file.c 69.5% <0%> (-0.28%) :arrow_down:
src/libpmemfile/path_resolve.c 87.57% <0%> (ø) :arrow_up:
src/libpmemfile-posix/dir.c 85.01% <0%> (+0.24%) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3f66ea...b52d627. Read the comment docs.

krzycz commented 7 years ago
:lgtm:

Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 5 of 5 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable