pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

Fix hook_faccessat #345

Closed GBuella closed 7 years ago

GBuella commented 7 years ago

This change is Reviewable

krzycz commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

GBuella commented 7 years ago

One can read about the difference between pmemfile_vfd_ref and pmemfile_vfd_at_ref : https://github.com/pmem/pmemfile/blob/master/src/libpmemfile/vfd_table.c#L223

codecov[bot] commented 7 years ago

Codecov Report

Merging #345 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   73.66%   73.67%   +0.01%     
==========================================
  Files          64       64              
  Lines        7990     7990              
  Branches     1613     1613              
==========================================
+ Hits         5886     5887       +1     
+ Misses       1588     1587       -1     
  Partials      516      516
Flag Coverage Δ
#sqlite_tests 45.87% <100%> (+0.26%) :arrow_up:
#tests_antool 12.21% <0%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.9% <0%> (-0.03%) :arrow_down:
#tests_posix_single_threaded 56.04% <0%> (ø) :arrow_up:
#tests_preload 45.48% <100%> (+0.04%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile/preload.c 47.11% <100%> (ø) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3f66ea...c346f46. Read the comment docs.

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 2 of 2 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable