Closed marcinslusarz closed 7 years ago
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #351 into master will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 75.05% 75.04% -0.02%
==========================================
Files 64 64
Lines 7921 7921
Branches 1589 1589
==========================================
- Hits 5945 5944 -1
Misses 1479 1479
- Partials 497 498 +1
Flag | Coverage Δ | |
---|---|---|
#sqlite_tests | 45.84% <ø> (-0.08%) |
:arrow_down: |
#tests_antool | 12.54% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.98% <ø> (+0.03%) |
:arrow_up: |
#tests_posix_single_threaded | 56% <ø> (+0.02%) |
:arrow_up: |
#tests_preload | 46.19% <ø> (-0.01%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/dir.c | 85.5% <0%> (-0.25%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6d1e91e...1c1902d. Read the comment docs.
FTR, previously chmod was failing like that:
[15:24:31] /root/pjdfstest/tests/chmod/01.t ............
1..5
ok 1
ok 2
ok 3
ok 4
ok 5
ok 5339 ms ( 0.01 usr 0.00 sys + 8.33 cusr 0.16 csys = 8.50 CPU)
[15:24:42] /root/pjdfstest/tests/chmod/02.t ............
1..5
ok 1
ok 2
ok 3
ok 4
ok 5
ok 10797 ms ( 0.00 usr 0.00 sys + 16.60 cusr 0.33 csys = 16.93 CPU)
rm: traversal failed: 2a406a57aa3f7671c03131e7fe4299cdf1d2dc8b6311e3d8c3c9793eac71b5e0fde8bcbf3bfba2114388ad307c78ef765e2d2462668b86f82510ab229559b52: Operation not supported
[15:26:39] /root/pjdfstest/tests/chmod/03.t ............
1..5
ok 1
ok 2
ok 3
ok 4
ok 5
Dubious, test returned 1 (wstat 256, 0x100)
All 5 subtests passed
[15:26:46] /root/pjdfstest/tests/chmod/04.t ............
1..7
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 7122 ms ( 0.01 usr 0.00 sys + 11.21 cusr 0.22 csys = 11.44 CPU)
Now it fails like that:
[12:38:56] /root/pjdfstest/tests/chmod/01.t ............
1..5
ok 1
ok 2
ok 3
ok 4
ok 5
ok 17956 ms ( 0.00 usr 0.00 sys + 21.25 cusr 0.85 csys = 22.10 CPU)
[12:39:31] /root/pjdfstest/tests/chmod/02.t ............
1..5
ok 1
ok 2
ok 3
ok 4
not ok 5 - tried 'chmod 8ed93a217bf5efa3eb50924bd73b6d1425bf1f46fb61c0bef21caa49fb0a6af741d0bf7800446831ae98759b6ae8c0766625aa7626d3000f581aa7c10fa72cd939d73f4ebb821a5b37f828e06e5dc403f5ae9dfb5698558d4f831f6682c9ce2a39b2b9bfe8aa026d8c67f7c4277cad7f15f075a623d36e60d4x 0620', expected ENAMETOOLONG, got ENOENT
Failed 1/5 subtests
[12:46:31] /root/pjdfstest/tests/chmod/03.t ............
1..5
ok 1
ok 2
ok 3
ok 4
ok 5
ok 419599 ms ( 0.00 usr 0.00 sys + 503.14 cusr 19.96 csys = 523.10 CPU)
[12:46:54] /root/pjdfstest/tests/chmod/04.t ............
1..7
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 22640 ms ( 0.01 usr 0.00 sys + 27.41 cusr 0.82 csys = 28.24 CPU)
It seems pjdfstest doesn't reliably report failed test number when test stops with non-zero exit status.
Now that we fixed the underlying issue (I think it was missing support for dup/dup2), we can see which of the sub-tests are failing.
This change is