Closed marcinslusarz closed 7 years ago
Merging #352 into master will decrease coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 75.05% 75.01% -0.04%
==========================================
Files 64 64
Lines 7921 7921
Branches 1589 1589
==========================================
- Hits 5945 5942 -3
- Misses 1479 1481 +2
- Partials 497 498 +1
Flag | Coverage Δ | |
---|---|---|
#sqlite_tests | 45.88% <ø> (-0.04%) |
:arrow_down: |
#tests_antool | 12.54% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.89% <ø> (-0.06%) |
:arrow_down: |
#tests_posix_single_threaded | 56% <ø> (+0.02%) |
:arrow_up: |
#tests_preload | 46.11% <ø> (-0.1%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/dir.c | 85.25% <0%> (-0.5%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 70.67% <0%> (-0.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6d1e91e...7a0134d. Read the comment docs.
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Even if we could fix tests to always hit all code paths, we can't fix gcov (which sometimes reports impossible coverage changes). The only sane solution is to allow coverage to drop by some small number. 0.2% seems to be enough to cover most problems.
https://docs.codecov.io/docs/commit-status#section-threshold
This change is