pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

preload: fix access mode argument #354

Closed llugin closed 7 years ago

llugin commented 7 years ago

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #354 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   75.05%   74.96%   -0.09%     
==========================================
  Files          64       64              
  Lines        7921     7921              
  Branches     1589     1589              
==========================================
- Hits         5945     5938       -7     
- Misses       1479     1481       +2     
- Partials      497      502       +5
Flag Coverage Δ
#sqlite_tests 45.99% <100%> (+0.07%) :arrow_up:
#tests_antool 12.54% <0%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.81% <0%> (-0.14%) :arrow_down:
#tests_posix_single_threaded 55.97% <0%> (ø) :arrow_up:
#tests_preload 46.09% <100%> (-0.12%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile/preload.c 49.16% <100%> (ø) :arrow_up:
src/libpmemfile-posix/rename.c 90.8% <0%> (-1.21%) :arrow_down:
src/libpmemfile-posix/dir.c 85.01% <0%> (-0.74%) :arrow_down:
src/libpmemfile-posix/read.c 92.51% <0%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d1e91e...f84c455. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #354 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   75.05%   74.96%   -0.09%     
==========================================
  Files          64       64              
  Lines        7921     7921              
  Branches     1589     1589              
==========================================
- Hits         5945     5938       -7     
- Misses       1479     1481       +2     
- Partials      497      502       +5
Flag Coverage Δ
#sqlite_tests 45.99% <100%> (+0.07%) :arrow_up:
#tests_antool 12.54% <0%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.81% <0%> (-0.14%) :arrow_down:
#tests_posix_single_threaded 55.97% <0%> (ø) :arrow_up:
#tests_preload 46.09% <100%> (-0.12%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile/preload.c 49.16% <100%> (ø) :arrow_up:
src/libpmemfile-posix/rename.c 90.8% <0%> (-1.21%) :arrow_down:
src/libpmemfile-posix/dir.c 85.01% <0%> (-0.74%) :arrow_down:
src/libpmemfile-posix/read.c 92.51% <0%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d1e91e...f84c455. Read the comment docs.

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

krzycz commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable