pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: change ftruncate errno for readonly file to EINVAL #361

Closed llugin closed 7 years ago

llugin commented 7 years ago

Fixing error occuring in LTP test ftruncate03.


This change is Reviewable

krzycz commented 7 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

marcinslusarz commented 7 years ago

Please add test case for that in tests/posix/rw/rw.cpp/ftruncate

codecov[bot] commented 7 years ago

Codecov Report

Merging #361 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   79.63%   79.64%   +<.01%     
==========================================
  Files          64       64              
  Lines        7920     7923       +3     
  Branches     1585     1586       +1     
==========================================
+ Hits         6307     6310       +3     
  Misses       1210     1210              
  Partials      403      403
Flag Coverage Δ
#ltp_tests 46.9% <0%> (+0.1%) :arrow_up:
#sqlite_tests 45.43% <0%> (-0.12%) :arrow_down:
#tests_antool 15.34% <0%> (-0.01%) :arrow_down:
#tests_posix_multi_threaded 25.91% <0%> (-0.04%) :arrow_down:
#tests_posix_single_threaded 56.26% <100%> (+0.01%) :arrow_up:
#tests_preload 46.23% <0%> (+0.07%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/truncate.c 90.26% <100%> (+0.26%) :arrow_up:
src/libpmemfile-posix/dir.c 85.01% <0%> (-0.99%) :arrow_down:
src/libpmemfile-posix/data.c 93.07% <0%> (+0.76%) :arrow_up:
src/libpmemfile-posix/rename.c 92% <0%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce57c2b...ae50da8. Read the comment docs.

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

krzycz commented 7 years ago

Coverage: -20%. WTH?


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

GBuella commented 7 years ago

Some tests failed. Coverage is reported for failed builds as well? Can we disable that?

marcinslusarz commented 7 years ago

I think it's CodeCov.io bug, so no.

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 3 of 3 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable