Closed ldorau closed 7 years ago
Reviewed 5 of 5 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
Merging #362 into master will decrease coverage by
0.03%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
- Coverage 79.63% 79.59% -0.04%
==========================================
Files 64 64
Lines 7920 7920
Branches 1585 1585
==========================================
- Hits 6307 6304 -3
- Misses 1210 1211 +1
- Partials 403 405 +2
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.8% <ø> (+0.01%) |
:arrow_up: |
#sqlite_tests | 45.53% <ø> (-0.02%) |
:arrow_down: |
#tests_antool | 15.35% <100%> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.88% <ø> (-0.08%) |
:arrow_down: |
#tests_posix_single_threaded | 56.24% <ø> (ø) |
:arrow_up: |
#tests_preload | 46.1% <ø> (-0.06%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/antool/listsyscalls.py | 99.43% <100%> (ø) |
:arrow_up: |
src/tools/antool/utils.py | 100% <100%> (ø) |
:arrow_up: |
src/tools/antool/syscall.py | 99.34% <100%> (ø) |
:arrow_up: |
src/libpmemfile-posix/dir.c | 84.76% <0%> (-1.23%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 74.86% <0%> (-0.28%) |
:arrow_down: |
src/libpmemfile-posix/data.c | 92.69% <0%> (+0.38%) |
:arrow_up: |
src/libpmemfile-posix/rename.c | 92% <0%> (+0.79%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ce57c2b...ef3da3f. Read the comment docs.
Replace the strings "can be corrupted" with "may be corrupted"
This change is