marcinslusarz commented 7 years ago

This change is

krzycz commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

utils/docker/images/install-nvml.sh, line 39 at r1 (raw file):

git clone https://github.com/pmem/nvml.git
cd nvml
#git checkout 3fdd3f91bf55d93779d05a680726f08c810511dd

rm

Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #364 into master will decrease coverage by 0.06%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   77.03%   76.96%   -0.07%     
==========================================
  Files          67       67              
  Lines        8235     8228       -7     
  Branches     1649     1649              
==========================================
- Hits         6344     6333      -11     
- Misses       1481     1488       +7     
+ Partials      410      407       -3

Flag	Coverage Δ
#ltp_tests	`46.6% <0%> (-0.24%)`	:arrow_down:
#sqlite_tests	`45.26% <0%> (-0.12%)`	:arrow_down:
#tests_antool	`14.77% <0%> (+0.01%)`	:arrow_up:
#tests_posix_multi_threaded	`25.59% <0%> (+0.38%)`	:arrow_up:
#tests_posix_single_threaded	`54.23% <0%> (-0.16%)`	:arrow_down:
#tests_preload	`44.93% <0%> (-0.11%)`	:arrow_down:

Impacted Files	Coverage Δ
src/libpmemfile-posix/block_array.c	`95.96% <0%> (-1.6%)`	:arrow_down:
src/libpmemfile-posix/stats.c	`47.5% <0%> (-10%)`	:arrow_down:
src/libpmemfile-posix/blocks.c	`62.5% <0%> (-7.5%)`	:arrow_down:
src/libpmemfile-posix/utils.c	`70% <0%> (-1.67%)`	:arrow_down:
src/libpmemfile-posix/file.c	`74.86% <0%> (-0.28%)`	:arrow_down:
src/libpmemfile-posix/inode.c	`88.65% <0%> (+0.34%)`	:arrow_up:
src/libpmemfile-posix/data.c	`94.42% <0%> (+0.39%)`	:arrow_up:
src/libpmemfile-posix/pool.c	`62.63% <0%> (+1.05%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3c4291...d0ec974. Read the comment docs.

krzycz commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

pmem / pmemfile

Downgrade NVML to 1.3 #364

Codecov Report