pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: add getdents einval and enoent handling #366

Closed llugin closed 7 years ago

llugin commented 7 years ago

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #366 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   76.94%   77.03%   +0.08%     
==========================================
  Files          67       67              
  Lines        8228     8234       +6     
  Branches     1649     1652       +3     
==========================================
+ Hits         6331     6343      +12     
+ Misses       1488     1486       -2     
+ Partials      409      405       -4
Flag Coverage Δ
#ltp_tests 46.53% <42.85%> (-0.03%) :arrow_down:
#sqlite_tests 45.27% <42.85%> (-0.06%) :arrow_down:
#tests_antool 14.76% <0%> (-0.02%) :arrow_down:
#tests_posix_multi_threaded 25.63% <42.85%> (-0.02%) :arrow_down:
#tests_posix_single_threaded 54.27% <100%> (+0.01%) :arrow_up:
#tests_preload 44.92% <42.85%> (+0.05%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/getdents.c 90.32% <100%> (+0.38%) :arrow_up:
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:
src/libpmemfile-posix/dir.c 85.74% <0%> (+0.73%) :arrow_up:
src/libpmemfile-posix/data.c 94.82% <0%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad333ec...b9531ba. Read the comment docs.

llugin commented 7 years ago

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


src/libpmemfile-posix/getdents.c, line 297 at r1 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…
Please remove curly braces for single line statements.

Done.


Comments from Reviewable

marcinslusarz commented 7 years ago
:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable