pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: do not add empty paths to pmem paths #368

Closed ldorau closed 7 years ago

ldorau commented 7 years ago

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #368 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   76.94%   76.97%   +0.02%     
==========================================
  Files          67       67              
  Lines        8228     8230       +2     
  Branches     1649     1650       +1     
==========================================
+ Hits         6331     6335       +4     
  Misses       1488     1488              
+ Partials      409      407       -2
Flag Coverage Δ
#ltp_tests 46.57% <ø> (+0.01%) :arrow_up:
#sqlite_tests 45.34% <ø> (+0.01%) :arrow_up:
#tests_antool 14.79% <100%> (+0.02%) :arrow_up:
#tests_posix_multi_threaded 25.63% <ø> (-0.02%) :arrow_down:
#tests_posix_single_threaded 54.23% <ø> (-0.03%) :arrow_down:
#tests_preload 44.93% <ø> (+0.07%) :arrow_up:
Impacted Files Coverage Δ
src/tools/antool/listsyscalls.py 99.44% <100%> (ø) :arrow_up:
src/libpmemfile-posix/dir.c 85.25% <0%> (+0.24%) :arrow_up:
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad333ec...b7fe753. Read the comment docs.

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable