pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: correct test for realpath() #370

Closed ldorau closed 7 years ago

ldorau commented 7 years ago

Move testing pmem paths to fault injection tests, because the 'dir_pmem.txt' file can be regenerated and modified.

Remove also incorrect check from realpath().


This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #370 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   76.94%   76.98%   +0.03%     
==========================================
  Files          67       67              
  Lines        8228     8228              
  Branches     1649     1649              
==========================================
+ Hits         6331     6334       +3     
+ Misses       1488     1487       -1     
+ Partials      409      407       -2
Flag Coverage Δ
#ltp_tests 46.59% <ø> (+0.03%) :arrow_up:
#sqlite_tests 45.34% <ø> (+0.01%) :arrow_up:
#tests_antool 14.77% <100%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.54% <ø> (-0.1%) :arrow_down:
#tests_posix_single_threaded 54.26% <ø> (ø) :arrow_up:
#tests_preload 44.8% <ø> (-0.06%) :arrow_down:
Impacted Files Coverage Δ
src/tools/antool/listsyscalls.py 99.43% <100%> (ø) :arrow_up:
src/libpmemfile-posix/file.c 74.86% <0%> (-0.28%) :arrow_down:
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:
src/libpmemfile-posix/dir.c 85.5% <0%> (+0.49%) :arrow_up:
src/libpmemfile/path_resolve.c 90.47% <0%> (+0.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad333ec...af017d9. Read the comment docs.

krzycz commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable