pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

preload: restore errno before returning to syscall_intercept #372

Closed marcinslusarz closed 7 years ago

marcinslusarz commented 7 years ago

This change is Reviewable

krzycz commented 7 years ago

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #372 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   76.94%   77.01%   +0.06%     
==========================================
  Files          67       67              
  Lines        8228     8230       +2     
  Branches     1649     1649              
==========================================
+ Hits         6331     6338       +7     
+ Misses       1488     1486       -2     
+ Partials      409      406       -3
Flag Coverage Δ
#ltp_tests 46.62% <81.81%> (+0.06%) :arrow_up:
#sqlite_tests 45.36% <90.9%> (+0.03%) :arrow_up:
#tests_antool 14.77% <0%> (-0.01%) :arrow_down:
#tests_posix_multi_threaded 25.61% <0%> (-0.04%) :arrow_down:
#tests_posix_single_threaded 54.24% <0%> (-0.02%) :arrow_down:
#tests_preload 44.98% <100%> (+0.12%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile/syscall_early_filter.c 80% <ø> (ø) :arrow_up:
src/libpmemfile/preload.c 54.2% <100%> (+0.08%) :arrow_up:
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:
src/libpmemfile-posix/dir.c 85.5% <0%> (+0.49%) :arrow_up:
src/libpmemfile-posix/data.c 94.82% <0%> (+0.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad333ec...7e7dcd7. Read the comment docs.

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable