Closed marcinslusarz closed 7 years ago
Merging #375 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 76.95% 76.96% +0.01%
==========================================
Files 67 67
Lines 8261 8261
Branches 1658 1658
==========================================
+ Hits 6357 6358 +1
+ Misses 1489 1487 -2
- Partials 415 416 +1
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.54% <ø> (+0.87%) |
:arrow_up: |
#sqlite_tests | 45.17% <ø> (-0.05%) |
:arrow_down: |
#tests_antool | 14.72% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.06% <ø> (-0.1%) |
:arrow_down: |
#tests_posix_single_threaded | 54.28% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.84% <ø> (+0.01%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/dir.c | 84.76% <0%> (-1.48%) |
:arrow_down: |
src/libpmemfile-posix/inode.c | 88.31% <0%> (-0.35%) |
:arrow_down: |
src/libpmemfile-posix/data.c | 94.02% <0%> (+0.39%) |
:arrow_up: |
src/libpmemfile-posix/block_array.c | 96.77% <0%> (+2.41%) |
:arrow_up: |
src/libpmemfile-posix/fcntl.c | 69.81% <0%> (+3.77%) |
:arrow_up: |
src/libpmemfile-posix/blocks.c | 70% <0%> (+5%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 467df9d...340ecbe. Read the comment docs.
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
The code looks ok. Why are you disabling these tests for external test jobs?
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
Because those tests are not used in those jobs (and there's no need to build gtest), so the whole build is tiny bit faster. It matters more when testing a subset of tests locally.
This change is