pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: fix antool fault injection tests with vltrace #376

Closed ldorau closed 7 years ago

ldorau commented 7 years ago

Antool's fault injection tests use one binary log file as an input file, so this one file has to be decompressed also when vltrace is run. This patch adds this functionality.

Antool's fault injection tests have been failing so far if they were run with vltrace, because vltrace overwrote their input file. This patch fixes this issue.

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #376 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   76.91%   77.06%   +0.15%     
==========================================
  Files          67       67              
  Lines        8261     8263       +2     
  Branches     1658     1659       +1     
==========================================
+ Hits         6354     6368      +14     
+ Misses       1489     1483       -6     
+ Partials      418      412       -6
Flag Coverage Δ
#ltp_tests 46.57% <ø> (+0.88%) :arrow_up:
#sqlite_tests 45.23% <ø> (-0.02%) :arrow_down:
#tests_antool 14.74% <100%> (+0.02%) :arrow_up:
#tests_posix_multi_threaded 25.09% <ø> (+0.01%) :arrow_up:
#tests_posix_single_threaded 54.31% <ø> (ø) :arrow_up:
#tests_preload 44.69% <ø> (-0.11%) :arrow_down:
Impacted Files Coverage Δ
src/tools/antool/listsyscalls.py 99.44% <100%> (ø) :arrow_up:
src/libpmemfile-posix/read.c 93.87% <0%> (-0.69%) :arrow_down:
src/libpmemfile/path_resolve.c 90.47% <0%> (+0.59%) :arrow_up:
src/libpmemfile-posix/dir.c 85.99% <0%> (+0.98%) :arrow_up:
src/libpmemfile-posix/data.c 94.82% <0%> (+1.19%) :arrow_up:
src/libpmemfile-posix/block_array.c 96.77% <0%> (+2.41%) :arrow_up:
src/libpmemfile-posix/blocks.c 70% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3f8791...ac25663. Read the comment docs.

krzycz commented 7 years ago

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

ldorau commented 7 years ago

Antool's fault injection tests use one binary log file as an input file, so this one file has to be decompressed also when vltrace is run. This patch adds this functionality.

Antool's fault injection tests have been failing so far if they were run with vltrace, because vltrace overwrote their input file. This patch fixes this issue.

krzycz commented 7 years ago

Reviewed 7 of 7 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Reviewed 4 of 6 files at r1, 7 of 7 files at r2. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable