Codecov Report

Merging #380 into master will increase coverage by 0.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   76.91%   77.04%   +0.13%     
==========================================
  Files          67       67              
  Lines        8261     8261              
  Branches     1658     1658              
==========================================
+ Hits         6354     6365      +11     
+ Misses       1489     1485       -4     
+ Partials      418      411       -7

Flag	Coverage Δ
#ltp_tests	`46.55% <ø> (+0.87%)`	:arrow_up:
#sqlite_tests	`45.3% <ø> (+0.05%)`	:arrow_up:
#tests_antool	`14.72% <ø> (ø)`	:arrow_up:
#tests_posix_multi_threaded	`25.12% <ø> (+0.03%)`	:arrow_up:
#tests_posix_single_threaded	`54.28% <ø> (-0.03%)`	:arrow_down:
#tests_preload	`44.79% <ø> (ø)`	:arrow_up:

Impacted Files	Coverage Δ
src/libpmemfile-posix/dir.c	`85.74% <0%> (+0.73%)`	:arrow_up:
src/libpmemfile-posix/data.c	`94.82% <0%> (+1.19%)`	:arrow_up:
src/libpmemfile-posix/block_array.c	`96.77% <0%> (+2.41%)`	:arrow_up:
src/libpmemfile-posix/blocks.c	`70% <0%> (+5%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3f8791...4adc890. Read the comment docs.

llugin commented 7 years ago

Review status: 0 of 17 files reviewed at latest revision, 1 unresolved discussion.

utils/docker/images/Dockerfile.fedora-23, line 43 at r2 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…

There is no need to specify architecture.

Done.

Comments from Reviewable

marcinslusarz commented 7 years ago

Reviewed 1 of 10 files at r1, 6 of 8 files at r2, 7 of 10 files at r3. Review status: 13 of 16 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

utils/docker/external_tests/run-build-suite.sh, line 56 at r3 (raw file):

SUITE=$1

SUITE_HOME=/home/user

Why not set SUITE_HOME to $HOME?

utils/docker/images/Dockerfile.fedora-23, line 43 at r2 (raw file):

Previously, llugin wrote…

Done.

Do I really have to point out each line where it wasn't "done"...?

Comments from Reviewable

llugin commented 7 years ago

Review status: 13 of 16 files reviewed at latest revision, 2 unresolved discussions.

utils/docker/external_tests/run-build-suite.sh, line 56 at r3 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…

Why not set SUITE_HOME to $HOME?

suites are installed by user, while xfs uses pmemfile-mount so it has to be run as root - in this case suites won't be found under $HOME

utils/docker/images/Dockerfile.fedora-23, line 43 at r2 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…

Do I really have to point out each line where it wasn't "done"...?

Done.

Comments from Reviewable

krzycz commented 7 years ago

Reviewed 1 of 10 files at r1, 6 of 8 files at r2, 7 of 10 files at r3, 3 of 3 files at r4. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

marcinslusarz commented 7 years ago

Reviewed 3 of 3 files at r4. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

sarahjelinek commented 6 years ago

Reviewed 1 of 10 files at r1, 6 of 8 files at r2, 7 of 10 files at r3, 3 of 3 files at r4. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

pmem / pmemfile

Docker: add xfs tests #380

Codecov Report