pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: detect unknown metadata blocks #382

Closed marcinslusarz closed 6 years ago

marcinslusarz commented 7 years ago

... and fix indentation


This change is Reviewable

krzycz commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #382 into master will increase coverage by 0.11%. The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   76.91%   77.02%   +0.11%     
==========================================
  Files          67       67              
  Lines        8261     8262       +1     
  Branches     1658     1658              
==========================================
+ Hits         6354     6364      +10     
+ Misses       1489     1487       -2     
+ Partials      418      411       -7
Flag Coverage Δ
#ltp_tests 46.53% <0%> (+0.85%) :arrow_up:
#sqlite_tests 45.26% <0%> (+0.01%) :arrow_up:
#tests_antool 14.71% <0%> (-0.01%) :arrow_down:
#tests_posix_multi_threaded 25.11% <54.54%> (+0.02%) :arrow_up:
#tests_posix_single_threaded 54.28% <72.72%> (-0.04%) :arrow_down:
#tests_preload 44.76% <0%> (-0.04%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/stats.c 56.09% <72.72%> (-1.41%) :arrow_down:
src/libpmemfile-posix/fcntl.c 66.03% <0%> (-3.78%) :arrow_down:
src/libpmemfile-posix/dir.c 85.99% <0%> (+0.98%) :arrow_up:
src/libpmemfile-posix/data.c 94.82% <0%> (+1.19%) :arrow_up:
src/libpmemfile-posix/block_array.c 96.77% <0%> (+2.41%) :arrow_up:
src/libpmemfile-posix/blocks.c 70% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3f8791...f96ee24. Read the comment docs.

sarahjelinek commented 6 years ago
:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable