pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: remove performance hack for pre-1.3 pmemobj #385

Closed marcinslusarz closed 6 years ago

marcinslusarz commented 7 years ago

This change is Reviewable

krzycz commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #385 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   76.91%   76.94%   +0.03%     
==========================================
  Files          67       67              
  Lines        8261     8260       -1     
  Branches     1658     1658              
==========================================
+ Hits         6354     6356       +2     
  Misses       1489     1489              
+ Partials      418      415       -3
Flag Coverage Δ
#ltp_tests 46.5% <100%> (+0.82%) :arrow_up:
#sqlite_tests 45.25% <100%> (ø) :arrow_up:
#tests_antool 14.72% <0%> (ø) :arrow_up:
#tests_posix_multi_threaded 25.1% <100%> (+0.01%) :arrow_up:
#tests_posix_single_threaded 54.28% <100%> (-0.04%) :arrow_down:
#tests_preload 44.8% <100%> (ø) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/block_array.c 96.74% <100%> (+2.39%) :arrow_up:
src/libpmemfile-posix/utils.c 70% <0%> (-1.67%) :arrow_down:
src/libpmemfile-posix/dir.c 84.76% <0%> (-0.25%) :arrow_down:
src/libpmemfile-posix/data.c 93.62% <0%> (ø) :arrow_up:
src/libpmemfile-posix/blocks.c 70% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3f8791...f13735c. Read the comment docs.

sarahjelinek commented 6 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable