Closed marcinslusarz closed 6 years ago
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #386 into master will increase coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 77% 77.03% +0.03%
==========================================
Files 67 67
Lines 8261 8261
Branches 1658 1658
==========================================
+ Hits 6361 6364 +3
+ Misses 1488 1484 -4
- Partials 412 413 +1
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.55% <ø> (+0.01%) |
:arrow_up: |
#sqlite_tests | 45.24% <ø> (-0.01%) |
:arrow_down: |
#tests_antool | 14.72% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.09% <ø> (+0.01%) |
:arrow_up: |
#tests_posix_single_threaded | 54.28% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.74% <ø> (-0.09%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/rename.c | 91.6% <0%> (-0.41%) |
:arrow_down: |
src/libpmemfile-posix/dir.c | 85.5% <0%> (+0.24%) |
:arrow_up: |
src/libpmemfile/path_resolve.c | 90.47% <0%> (+0.59%) |
:arrow_up: |
src/libpmemfile-posix/fcntl.c | 69.81% <0%> (+3.77%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 63d2f48...d7d369b. Read the comment docs.
Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Comments from Reviewable
... which can lead to buffer overflow and stack corruption.
Found by Coverity.
This change is