pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: fix match file of 'antool-analyze' test #391

Closed ldorau closed 6 years ago

ldorau commented 6 years ago

Ten SyS_mmap calls come from ten pthread_create() calls in this file. It happens that not all of them are detected, what causes sporadic failures of this test. Make them optional, because detecting all of them is not important.


This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #391 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   76.87%   76.89%   +0.02%     
==========================================
  Files          67       67              
  Lines        8276     8276              
  Branches     1665     1665              
==========================================
+ Hits         6362     6364       +2     
  Misses       1495     1495              
+ Partials      419      417       -2
Flag Coverage Δ
#ltp_tests 46.45% <ø> (+0.01%) :arrow_up:
#sqlite_tests 45.15% <ø> (-0.01%) :arrow_down:
#tests_antool 14.71% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 25.02% <ø> (-0.03%) :arrow_down:
#tests_posix_single_threaded 54.21% <ø> (ø) :arrow_up:
#tests_preload 44.65% <ø> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:
src/libpmemfile-posix/data.c 94.82% <0%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af46c7f...bdca361. Read the comment docs.

marcinslusarz commented 6 years ago

This looks suspiciously like a threading bug in vltrace...

ldorau commented 6 years ago

@marcinslusarz

This looks suspiciously like a threading bug in vltrace...

The reason is: pthread_create() fails with the error "Resource temporarily unavailable" in tested application, not in vltrace.

ldorau commented 6 years ago

pthread_create() may sometimes fail, so this test may too, so let's leave it as is.