Closed ldorau closed 6 years ago
Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.
Comments from Reviewable
Merging #392 into master will increase coverage by
0.04%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 76.87% 76.91% +0.04%
==========================================
Files 67 67
Lines 8276 8279 +3
Branches 1665 1666 +1
==========================================
+ Hits 6362 6368 +6
- Misses 1495 1496 +1
+ Partials 419 415 -4
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.43% <ø> (ø) |
:arrow_up: |
#sqlite_tests | 45.15% <ø> (-0.01%) |
:arrow_down: |
#tests_antool | 14.74% <100%> (+0.03%) |
:arrow_up: |
#tests_posix_multi_threaded | 25.04% <ø> (ø) |
:arrow_up: |
#tests_posix_single_threaded | 54.21% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.56% <ø> (-0.1%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/antool/listsyscalls.py | 99.44% <100%> (ø) |
:arrow_up: |
src/libpmemfile-posix/fcntl.c | 66.03% <0%> (-3.78%) |
:arrow_down: |
src/libpmemfile-posix/inode.c | 88.65% <0%> (+0.34%) |
:arrow_up: |
src/libpmemfile-posix/data.c | 94.82% <0%> (+0.39%) |
:arrow_up: |
src/libpmemfile-posix/dir.c | 85.74% <0%> (+0.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update af46c7f...e3626bf. Read the comment docs.
This change is