Closed GBuella closed 7 years ago
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.
Comments from Reviewable
Merging #396 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 77.04% 77.05% +0.01%
==========================================
Files 67 67
Lines 8330 8330
Branches 1678 1678
==========================================
+ Hits 6418 6419 +1
Misses 1495 1495
+ Partials 417 416 -1
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.48% <ø> (+0.04%) |
:arrow_up: |
#sqlite_tests | 45.14% <ø> (-0.04%) |
:arrow_down: |
#tests_antool | 15.24% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 24.99% <ø> (-0.08%) |
:arrow_down: |
#tests_posix_single_threaded | 54.21% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.56% <ø> (-0.2%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/data.c | 94.82% <ø> (+0.39%) |
:arrow_up: |
src/libpmemfile-posix/rename.c | 90.87% <0%> (-0.4%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 74.44% <0%> (-0.28%) |
:arrow_down: |
src/libpmemfile/preload.c | 54.09% <0%> (+0.09%) |
:arrow_up: |
src/libpmemfile/path_resolve.c | 90.47% <0%> (+0.59%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d484fc5...51e1927. Read the comment docs.
Merging #396 into master will increase coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 77.04% 77.05% +0.01%
==========================================
Files 67 67
Lines 8330 8330
Branches 1678 1678
==========================================
+ Hits 6418 6419 +1
Misses 1495 1495
+ Partials 417 416 -1
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 46.48% <ø> (+0.04%) |
:arrow_up: |
#sqlite_tests | 45.14% <ø> (-0.04%) |
:arrow_down: |
#tests_antool | 15.24% <ø> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 24.99% <ø> (-0.08%) |
:arrow_down: |
#tests_posix_single_threaded | 54.21% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.56% <ø> (-0.2%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/libpmemfile-posix/data.c | 94.82% <ø> (+0.39%) |
:arrow_up: |
src/libpmemfile-posix/rename.c | 90.87% <0%> (-0.4%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 74.44% <0%> (-0.28%) |
:arrow_down: |
src/libpmemfile/preload.c | 54.09% <0%> (+0.09%) |
:arrow_up: |
src/libpmemfile/path_resolve.c | 90.47% <0%> (+0.59%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d484fc5...51e1927. Read the comment docs.
This change is