pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

preload: fix utime and utimes for NULL time #405

Closed marcinslusarz closed 6 years ago

marcinslusarz commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #405 into master will increase coverage by 0.06%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   77.09%   77.16%   +0.06%     
==========================================
  Files          67       67              
  Lines        8493     8499       +6     
  Branches     1698     1700       +2     
==========================================
+ Hits         6548     6558      +10     
  Misses       1515     1515              
+ Partials      430      426       -4
Flag Coverage Δ
#ltp_tests 46.95% <0%> (-0.5%) :arrow_down:
#sqlite_tests 46.09% <50%> (+0.16%) :arrow_up:
#tests_antool 14.95% <0%> (-0.02%) :arrow_down:
#tests_posix_multi_threaded 26.07% <0%> (+0.01%) :arrow_up:
#tests_posix_single_threaded 54.61% <0%> (-0.02%) :arrow_down:
#tests_preload 45.2% <0%> (-0.11%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile/preload.c 53.97% <50%> (-0.03%) :arrow_down:
src/libpmemfile-posix/inode.c 88.65% <0%> (+0.34%) :arrow_up:
src/libpmemfile-posix/dir.c 85.74% <0%> (+0.49%) :arrow_up:
src/libpmemfile/libpmemfile-posix-wrappers.h 69.76% <0%> (+1.16%) :arrow_up:
src/libpmemfile-posix/fcntl.c 65.43% <0%> (+2.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44cebf7...0cf2b1e. Read the comment docs.

sarahjelinek commented 6 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

sarahjelinek commented 6 years ago

Why is codecov so low?

marcinslusarz commented 6 years ago

I had to rebase to resolve conflict. Let's see if it also resolves the problem with coverage (it frequently does).