Codecov Report

Merging #406 into master will decrease coverage by 0.22%. The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   77.01%   76.78%   -0.23%     
==========================================
  Files          67       67              
  Lines        8330     8358      +28     
  Branches     1678     1684       +6     
==========================================
+ Hits         6415     6418       +3     
- Misses       1497     1523      +26     
+ Partials      418      417       -1

Flag	Coverage Δ
#ltp_tests	`46.27% <6.66%> (-0.17%)`	:arrow_down:
#sqlite_tests	`44.95% <0%> (-0.21%)`	:arrow_down:
#tests_antool	`15.19% <0%> (-0.06%)`	:arrow_down:
#tests_posix_multi_threaded	`24.9% <0%> (-0.2%)`	:arrow_down:
#tests_posix_single_threaded	`54.04% <16.66%> (-0.18%)`	:arrow_down:
#tests_preload	`44.47% <6.66%> (-0.51%)`	:arrow_down:

Impacted Files	Coverage Δ
src/libpmemfile-posix/fcntl.c	`46.91% <16.66%> (-22.9%)`	:arrow_down:
src/libpmemfile-posix/file.c	`74.44% <0%> (-0.28%)`	:arrow_down:
src/libpmemfile/path_resolve.c	`90.47% <0%> (+0.59%)`	:arrow_up:
src/libpmemfile-posix/data.c	`94.82% <0%> (+0.79%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5befca3...b6210d8. Read the comment docs.

sarahjelinek commented 7 years ago

Reviewed 2 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

pmem / pmemfile

posix: implement fcntl(..., F_SETFL, ...) #406

Codecov Report