pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

tests: Move some implemenations .hpp -> .cpp #413

Closed GBuella closed 7 years ago

GBuella commented 7 years ago

This change is Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #413 into master will decrease coverage by 0.18%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   77.15%   76.96%   -0.19%     
==========================================
  Files          67       67              
  Lines        8536     8536              
  Branches     1708     1708              
==========================================
- Hits         6586     6570      -16     
- Misses       1519     1537      +18     
+ Partials      431      429       -2
Flag Coverage Δ
#ltp_tests 46.66% <ø> (-0.27%) :arrow_down:
#sqlite_tests 46.2% <ø> (-0.03%) :arrow_down:
#tests_antool 14.89% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 26.04% <ø> (-0.1%) :arrow_down:
#tests_posix_single_threaded 54.68% <ø> (+0.02%) :arrow_up:
#tests_preload 45.46% <ø> (+0.09%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/fcntl.c 46.91% <0%> (-16.05%) :arrow_down:
src/libpmemfile-posix/dir.c 85.04% <0%> (-0.5%) :arrow_down:
src/libpmemfile-posix/write.c 86.38% <0%> (-0.47%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a34056a...e15438e. Read the comment docs.

krzycz commented 7 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

sarahjelinek commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable