pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: two minor fixes #417

Closed ldorau closed 6 years ago

ldorau commented 6 years ago

This change is Reviewable

krzycz commented 6 years ago

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #417 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   76.01%   75.99%   -0.03%     
==========================================
  Files          68       68              
  Lines        8765     8765              
  Branches     1787     1787              
==========================================
- Hits         6663     6661       -2     
- Misses       1609     1610       +1     
- Partials      493      494       +1
Flag Coverage Δ
#ltp_tests 44.97% <ø> (-0.09%) :arrow_down:
#sqlite_tests 44.9% <ø> (-0.08%) :arrow_down:
#tests_antool 14.62% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 25.49% <ø> (-0.02%) :arrow_down:
#tests_posix_single_threaded 53.51% <ø> (+0.02%) :arrow_up:
#tests_preload 44.47% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/data.c 94.11% <0%> (-0.79%) :arrow_down:
src/libpmemfile-posix/write.c 84.5% <0%> (-0.47%) :arrow_down:
src/libpmemfile-posix/file.c 74.04% <0%> (-0.28%) :arrow_down:
src/libpmemfile/preload.c 51.27% <0%> (-0.08%) :arrow_down:
src/libpmemfile-posix/inode.c 89.21% <0%> (+0.32%) :arrow_up:
src/libpmemfile-posix/dir.c 85.78% <0%> (+0.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74659ac...982634e. Read the comment docs.

krzycz commented 6 years ago

Reviewed 1 of 2 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

marcinslusarz commented 6 years ago
:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

ldorau commented 6 years ago

@marcinslusarz

The following tests FAILED:
     36 - mt_rename_drd (Failed)
Errors while running CTest
marcinslusarz commented 6 years ago

The issue in mt_rename_drd is fixed by #422.