pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

antool: add support for missing entry packets #418

Closed ldorau closed 6 years ago

ldorau commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #418 into master will decrease coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   76.01%   75.89%   -0.12%     
==========================================
  Files          68       68              
  Lines        8765     8767       +2     
  Branches     1787     1776      -11     
==========================================
- Hits         6663     6654       -9     
- Misses       1609     1623      +14     
+ Partials      493      490       -3
Flag Coverage Δ
#ltp_tests 44.8% <ø> (-0.26%) :arrow_down:
#sqlite_tests 44.97% <ø> (-0.01%) :arrow_down:
#tests_antool 14.65% <100%> (+0.03%) :arrow_up:
#tests_posix_multi_threaded 25.49% <ø> (-0.02%) :arrow_down:
#tests_posix_single_threaded 53.48% <ø> (ø) :arrow_up:
#tests_preload 44.61% <ø> (+0.14%) :arrow_up:
Impacted Files Coverage Δ
src/tools/antool/antool.py 100% <100%> (ø) :arrow_up:
src/tools/antool/syscall.py 99.66% <100%> (+0.32%) :arrow_up:
src/tools/antool/listsyscalls.py 99.48% <100%> (ø) :arrow_up:
src/libpmemfile-posix/fcntl.c 49.38% <0%> (-13.59%) :arrow_down:
src/libpmemfile-posix/data.c 94.11% <0%> (-0.79%) :arrow_down:
src/libpmemfile-posix/write.c 84.5% <0%> (-0.47%) :arrow_down:
src/libpmemfile/preload.c 51.27% <0%> (-0.08%) :arrow_down:
src/libpmemfile-posix/dir.c 85.53% <0%> (+0.24%) :arrow_up:
src/libpmemfile-posix/inode.c 89.21% <0%> (+0.32%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74659ac...3d456be. Read the comment docs.

krzycz commented 6 years ago

Reviewed 14 of 14 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

ldorau commented 6 years ago

WIP - do not merge it yet, one issue found

ldorau commented 6 years ago

All issues fixed