Closed ldorau closed 7 years ago
Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #424 into master will decrease coverage by
0.05%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 76.04% 75.98% -0.06%
==========================================
Files 68 68
Lines 8763 8763
Branches 1775 1775
==========================================
- Hits 6664 6659 -5
- Misses 1607 1610 +3
- Partials 492 494 +2
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 45.01% <ø> (+0.02%) |
:arrow_up: |
#sqlite_tests | 44.94% <ø> (ø) |
:arrow_up: |
#tests_antool | 14.65% <100%> (ø) |
:arrow_up: |
#tests_posix_multi_threaded | 25.43% <ø> (-0.07%) |
:arrow_down: |
#tests_posix_single_threaded | 53.48% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.5% <ø> (-0.07%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/antool/listsyscalls.py | 99.47% <ø> (-0.01%) |
:arrow_down: |
src/tools/antool/antool.py | 100% <100%> (ø) |
:arrow_up: |
src/libpmemfile/path_resolve.c | 88.69% <0%> (-0.6%) |
:arrow_down: |
src/libpmemfile-posix/dir.c | 85.29% <0%> (-0.5%) |
:arrow_down: |
src/libpmemfile-posix/inode.c | 88.74% <0%> (-0.34%) |
:arrow_down: |
src/libpmemfile-posix/file.c | 74.04% <0%> (-0.28%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 14a46b5...f077dc5. Read the comment docs.
Move two functions:
This change is