Closed ldorau closed 6 years ago
Reviewed 11 of 11 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Merging #425 into master will increase coverage by
0.06%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 75.85% 75.92% +0.06%
==========================================
Files 68 70 +2
Lines 8763 8805 +42
Branches 1775 1779 +4
==========================================
+ Hits 6647 6685 +38
- Misses 1625 1627 +2
- Partials 491 493 +2
Flag | Coverage Δ | |
---|---|---|
#ltp_tests | 43.96% <ø> (-0.81%) |
:arrow_down: |
#sqlite_tests | 44.95% <ø> (-0.06%) |
:arrow_down: |
#tests_antool | 15.06% <100%> (+0.41%) |
:arrow_up: |
#tests_posix_multi_threaded | 25.47% <ø> (+0.02%) |
:arrow_up: |
#tests_posix_single_threaded | 53.45% <ø> (ø) |
:arrow_up: |
#tests_preload | 44.52% <ø> (+0.04%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/antool/analyzer.py | 100% <100%> (ø) |
|
src/tools/antool/converter.py | 100% <100%> (ø) |
|
src/tools/antool/syscall.py | 99.66% <100%> (ø) |
:arrow_up: |
src/tools/antool/antool.py | 100% <100%> (ø) |
:arrow_up: |
src/tools/antool/listsyscalls.py | 99.48% <100%> (ø) |
:arrow_up: |
src/libpmemfile-posix/blocks.c | 65% <0%> (-5%) |
:arrow_down: |
src/libpmemfile-posix/block_array.c | 94.3% <0%> (-2.44%) |
:arrow_down: |
src/libpmemfile-posix/data.c | 93.72% <0%> (-1.18%) |
:arrow_down: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 56e2d28...4bf11e5. Read the comment docs.
This change is