pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: changed ifndef and include order in blocks.h #428

Closed igchor closed 6 years ago

igchor commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #428 into master will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
- Coverage   76.17%   76.09%   -0.08%     
==========================================
  Files          70       70              
  Lines        8805     8805              
  Branches     1779     1779              
==========================================
- Hits         6707     6700       -7     
- Misses       1606     1610       +4     
- Partials      492      495       +3
Flag Coverage Δ
#ltp_tests 44.95% <ø> (-0.05%) :arrow_down:
#sqlite_tests 44.96% <ø> (ø) :arrow_up:
#tests_antool 15.06% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 25.48% <ø> (-0.06%) :arrow_down:
#tests_posix_single_threaded 53.45% <ø> (ø) :arrow_up:
#tests_preload 44.59% <ø> (+0.04%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/blocks.h 100% <ø> (ø) :arrow_up:
src/libpmemfile-posix/fcntl.c 62.96% <0%> (-2.47%) :arrow_down:
src/libpmemfile-posix/rename.c 90.32% <0%> (-0.81%) :arrow_down:
src/libpmemfile-posix/data.c 94.11% <0%> (-0.79%) :arrow_down:
src/libpmemfile-posix/inode.c 88.74% <0%> (-0.34%) :arrow_down:
src/libpmemfile-posix/dir.c 85.53% <0%> (-0.25%) :arrow_down:
src/libpmemfile-posix/write.c 84.97% <0%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22b756b...6cf0031. Read the comment docs.

krzycz commented 6 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

marcinslusarz commented 6 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable