pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: fix possible use after free #430

Closed marcinslusarz closed 6 years ago

marcinslusarz commented 6 years ago

Reported by Coverity. Fallout from f60769a0891a38dd1decdbd28abdd79ec010b9ac.


This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #430 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #430      +/-   ##
=========================================
- Coverage   76.11%   76.1%   -0.01%     
=========================================
  Files          70      70              
  Lines        8814    8815       +1     
  Branches     1781    1781              
=========================================
  Hits         6709    6709              
  Misses       1610    1610              
- Partials      495     496       +1
Flag Coverage Δ
#ltp_tests 44.99% <0%> (-0.01%) :arrow_down:
#sqlite_tests 44.97% <0%> (-0.01%) :arrow_down:
#tests_antool 15.05% <0%> (-0.01%) :arrow_down:
#tests_posix_multi_threaded 25.5% <0%> (-0.08%) :arrow_down:
#tests_posix_single_threaded 53.49% <100%> (ø) :arrow_up:
#tests_preload 44.51% <0%> (-0.13%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/file.c 74.86% <100%> (+0.06%) :arrow_up:
src/libpmemfile-posix/utils.c 66.66% <0%> (-1.67%) :arrow_down:
src/libpmemfile-posix/rename.c 90.32% <0%> (-0.81%) :arrow_down:
src/libpmemfile/path_resolve.c 88.69% <0%> (-0.6%) :arrow_down:
src/libpmemfile-posix/write.c 84.5% <0%> (-0.47%) :arrow_down:
src/libpmemfile-posix/data.c 94.9% <0%> (+0.78%) :arrow_up:
src/libpmemfile-posix/fcntl.c 65.43% <0%> (+2.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d05f760...f3f061c. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #430 into master will decrease coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #430      +/-   ##
=========================================
- Coverage   76.11%   76.1%   -0.01%     
=========================================
  Files          70      70              
  Lines        8814    8815       +1     
  Branches     1781    1781              
=========================================
  Hits         6709    6709              
  Misses       1610    1610              
- Partials      495     496       +1
Flag Coverage Δ
#ltp_tests 44.99% <0%> (-0.01%) :arrow_down:
#sqlite_tests 44.97% <0%> (-0.01%) :arrow_down:
#tests_antool 15.05% <0%> (-0.01%) :arrow_down:
#tests_posix_multi_threaded 25.5% <0%> (-0.08%) :arrow_down:
#tests_posix_single_threaded 53.49% <100%> (ø) :arrow_up:
#tests_preload 44.51% <0%> (-0.13%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/file.c 74.86% <100%> (+0.06%) :arrow_up:
src/libpmemfile-posix/utils.c 66.66% <0%> (-1.67%) :arrow_down:
src/libpmemfile-posix/rename.c 90.32% <0%> (-0.81%) :arrow_down:
src/libpmemfile/path_resolve.c 88.69% <0%> (-0.6%) :arrow_down:
src/libpmemfile-posix/write.c 84.5% <0%> (-0.47%) :arrow_down:
src/libpmemfile-posix/data.c 94.9% <0%> (+0.78%) :arrow_up:
src/libpmemfile-posix/fcntl.c 65.43% <0%> (+2.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d05f760...f3f061c. Read the comment docs.