pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: don't evaluate ASSERT args in release mode #436

Closed marcinslusarz closed 7 years ago

marcinslusarz commented 7 years ago

This change is Reviewable

krzycz commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

GBuella commented 7 years ago
:lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

codecov[bot] commented 7 years ago

Codecov Report

Merging #436 into master will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   79.46%   79.49%   +0.03%     
==========================================
  Files          71       71              
  Lines        8749     8749              
  Branches     1769     1770       +1     
==========================================
+ Hits         6952     6955       +3     
  Misses       1349     1349              
+ Partials      448      445       -3
Flag Coverage Δ
#ltp_tests 45.78% <ø> (+0.27%) :arrow_up:
#sqlite_tests 45.61% <ø> (-0.06%) :arrow_down:
#tests_antool 15.16% <ø> (ø) :arrow_up:
#tests_posix_multi_threaded 25.58% <ø> (-0.04%) :arrow_down:
#tests_posix_single_threaded 57.46% <ø> (-0.03%) :arrow_down:
#tests_preload 45.12% <ø> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
src/libpmemfile-posix/out.h 0% <ø> (ø) :arrow_up:
src/libpmemfile-posix/rename.c 91.49% <0%> (-0.41%) :arrow_down:
src/libpmemfile-posix/write.c 87.55% <0%> (+0.47%) :arrow_up:
src/libpmemfile-posix/dir.c 90.93% <0%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0aa79fa...ba99988. Read the comment docs.