pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

posix: add some logging for permission checks #439

Closed marcinslusarz closed 6 years ago

marcinslusarz commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #439 into master will decrease coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage    78.9%   78.87%   -0.04%     
==========================================
  Files          71       71              
  Lines        8809     8815       +6     
  Branches     1774     1775       +1     
==========================================
+ Hits         6951     6953       +2     
- Misses       1409     1412       +3     
- Partials      449      450       +1
Flag Coverage Δ
#ltp_tests 45.67% <71.42%> (+0.16%) :arrow_up:
#sqlite_tests 45.63% <71.42%> (-0.04%) :arrow_down:
#tests_antool 15.05% <0%> (-0.02%) :arrow_down:
#tests_posix_multi_threaded 25.34% <28.57%> (+0.03%) :arrow_up:
#tests_posix_single_threaded 57.03% <100%> (+0.03%) :arrow_up:
#tests_preload 44.7% <71.42%> (+0.03%) :arrow_up:
Impacted Files Coverage Δ
src/libpmemfile-posix/file.c 83.24% <100%> (+0.08%) :arrow_up:
src/libpmemfile-posix/dir.c 90.7% <100%> (+0.51%) :arrow_up:
src/libpmemfile-posix/creds.c 87.65% <100%> (+0.15%) :arrow_up:
src/libpmemfile-posix/offset_mapping.c 85% <0%> (-1.43%) :arrow_down:
src/libpmemfile-posix/rename.c 91.09% <0%> (-0.81%) :arrow_down:
src/libpmemfile-posix/data.c 94.09% <0%> (-0.79%) :arrow_down:
src/libpmemfile-posix/inode.c 88.41% <0%> (-0.34%) :arrow_down:
src/libpmemfile-posix/write.c 87.55% <0%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbb67ef...780f16e. Read the comment docs.

krzycz commented 6 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

GBuella commented 6 years ago
:lgtm:

Reviewed 3 of 3 files at r1. Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable