pmem / pmemfile

Userspace implementation of file APIs using persistent memory.
Other
34 stars 21 forks source link

common: s/NVML/PMDK/ #443

Open GBuella opened 6 years ago

GBuella commented 6 years ago

This change is Reviewable

codecov[bot] commented 6 years ago

Codecov Report

Merging #443 into master will decrease coverage by 29.51%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #443       +/-   ##
===========================================
- Coverage   83.91%   54.39%   -29.52%     
===========================================
  Files          71       56       -15     
  Lines        8815     7017     -1798     
  Branches      269        0      -269     
===========================================
- Hits         7397     3817     -3580     
- Misses       1414     3200     +1786     
+ Partials        4        0        -4
Flag Coverage Δ
#ltp_tests 54.39% <100%> (+0.69%) :arrow_up:
#sqlite_tests ?
#tests_antool ?
#tests_posix_multi_threaded ?
#tests_posix_single_threaded ?
#tests_preload ?
Impacted Files Coverage Δ
src/libpmemfile-posix/out.c 43.67% <100%> (-9.5%) :arrow_down:
src/libpmemfile-posix/mknod.c 0% <0%> (-100%) :arrow_down:
src/libpmemfile-posix/copy_file_range.c 0% <0%> (-100%) :arrow_down:
src/libpmemfile-posix/access.c 0% <0%> (-100%) :arrow_down:
src/libpmemfile-posix/flock.c 0% <0%> (-100%) :arrow_down:
src/libpmemfile-posix/mmap.c 0% <0%> (-100%) :arrow_down:
src/libpmemfile-posix/link.c 0% <0%> (-98.97%) :arrow_down:
src/libpmemfile-posix/timestamps.c 0% <0%> (-96.86%) :arrow_down:
src/libpmemfile-posix/fallocate.c 0% <0%> (-96.39%) :arrow_down:
src/libpmemfile-posix/rename.c 0% <0%> (-95.15%) :arrow_down:
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1b9897...e781bb5. Read the comment docs.

GBuella commented 6 years ago

Although this docker script still installs NVML, from before the rename has happened: utils/docker/images/install-pmdk.sh

GBuella commented 6 years ago

Oh well.

Rebuilding the Docker image for the Dockerfile.ubuntu-17.04

Reading package lists...
W: The repository 'http://security.ubuntu.com/ubuntu zesty-security Release' does not have a Release file.
W: The repository 'http://archive.ubuntu.com/ubuntu zesty Release' does not have a Release file.
W: The repository 'http://archive.ubuntu.com/ubuntu zesty-updates Release' does not have a Release file.
W: The repository 'http://archive.ubuntu.com/ubuntu zesty-backports Release' does not have a Release file.
E: Failed to fetch http://security.ubuntu.com/ubuntu/dists/zesty-security/universe/source/Sources  404  Not Found [IP: 91.189.88.152 80]
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/zesty/universe/source/Sources  404  Not Found [IP: 91.189.88.149 80]
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/zesty-updates/universe/source/Sources  404  Not Found [IP: 91.189.88.149 80]
E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/zesty-backports/multiverse/binary-amd64/Packages  404  Not Found [IP: 91.189.88.149 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command '/bin/sh -c apt-get update' returned a non-zero code: 100