search

pmem / pmemkv-python

Python bindings for pmemkv
https://pmem.io
BSD 3-Clause "New" or "Revised" License
13 stars 20 forks source link

Refactor part two #20

Closed karczex closed 4 years ago

karczex commented 4 years ago

This change is Reviewable

pmem-bot commented 4 years ago

@szyrom and @ldorau please review this pull request

karczex commented 4 years ago

tests/pmemkv_tests.py, line 258 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
why removing these?

Removing part of test related to removed API function get_keys_strings()

karczex commented 4 years ago

pmemkv/kvengine.cc, line 286 at r3 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…
what about pmemkv_errormsg in exception message?

Here should be thrown PmemkvException (which should be added) instead of general exception. In such exception, error message should be added. It's related to this issue: https://github.com/pmem/pmemkv-python/issues/18