pmem / pmemkv

Key/Value Datastore for Persistent Memory
https://pmem.io
Other
397 stars 120 forks source link

Revert "jenkins: add more prints and remove redundant code" #1049

Closed karczex closed 2 years ago

karczex commented 2 years ago

This partially reverts commit 72394725dd4903a9080f44f596c71cf9ad84ae6b.

It seems it's not the best idea to add random prints to bash script functions, as in bash the echo statement is treated as function return value.


This change is Reviewable

karczex commented 2 years ago

utils/jenkins/scripts/removeNamespaces.sh, line 3 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
-2021

Of course, I will change it, but... if you revert last change in the file should copyright stay incremented?

codecov[bot] commented 2 years ago

Codecov Report

Merging #1049 (08d4f78) into master (7c0c8ed) will increase coverage by 0.07%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   92.78%   92.86%   +0.07%     
==========================================
  Files          37       37              
  Lines        3772     3768       -4     
==========================================
- Hits         3500     3499       -1     
+ Misses        272      269       -3     
Impacted Files Coverage Δ
src/comparator/pmemobj_comparator.h 81.81% <0.00%> (-3.90%) :arrow_down:
src/engines-experimental/robinhood.cc 90.64% <0.00%> (-0.33%) :arrow_down:
src/config.h 94.94% <0.00%> (+4.56%) :arrow_up: